Possible error in service reminder script

Multidrive
Posts: 8
Joined: Thu Mar 14, 2013 9:44 am

Possible error in service reminder script

Post by Multidrive » Tue Nov 24, 2015 9:09 am

Hi,

I've just been adding a 6th service reminder to the standard configuration for the PV780 and came across the following in the serviceReminderScripts_T0Keyboard$:

//---------------------------------------------------------------------------------------------
// Murphy Scripting
// - Leave EventName as $ServiceReminderScripts_ToKeyboard$ for main script method
//---------------------------------------------------------------------------------------------
void $ServiceReminderScripts_ToKeyboard$ ()
{
int intervalValue = 0;

// Read which row we are on.
int valueToRead = 0;
smRead(VariableIDs.ServRemSelectedRow,valueToRead);

// Based on the row get the Interval Value.
if (valueToRead == 0)
{
smRead(VariableIDs.ServRemInterval1,intervalValue);
}
else if (valueToRead == 1)
{
smRead(VariableIDs.ServRemInterval2,intervalValue);
}
else if (valueToRead == 2)
{
smRead(VariableIDs.ServRemInterval3,intervalValue);
}
else if (valueToRead == 3)
{
smRead(VariableIDs.ServRemInterval4,intervalValue);
}
else if (valueToRead == 45)
{
smRead(VariableIDs.ServRemInterval5,intervalValue);
}

// Convert the value to a string for the keyboard.
string myValue = "";
if (intervalValue > 0)
myValue = myValue + intervalValue;

cultureSetString( StringIDs.ServiceIntervalEdit, myValue, true);

In the line that reads row 4 it actually reads 45 - Is this correct or just a typo? If it's a typo I think it's in all the sample service reminder scripts so I'm guessing something might go wrong at a 2,000 hour service?

I was planning to add a line for row 5 but if this is correct should it be changed when an extra row is added?

Regards
Tony
stalley
Enovation Controls Development
Enovation Controls Development
Posts: 618
Joined: Tue Mar 18, 2014 12:57 pm

Re: Possible error in service reminder script

Post by stalley » Tue Nov 24, 2015 9:23 am

Hello Multidrive,

Thanks for bringing this to our attention. Indeed, it does appear to be a typo in the script. I hope this hasn't been an inconvenience to you or anyone else.

We appreciate your time and consideration.
Sara Talley
Software Engineer
Enovation Controls